[Migrated PR #34] [FIX] Clear Qodana release blockers #20

New issue

Closed

opened 2026-10-09 04:25:52 +00:00 by moeardent · 2 comments

moeardent commented

2026-10-09 04:25:52 +00:00

Owner

Summary

Change class: FIX
Promotion target: dev
Trace ref: MOE-2 / TeamCity 11262

Scope

Included

Remediate all five Qodana findings from exact-main build 11262.
Correct reconciliation fallback trigger selection.
Make controlled prototype validator hashing checkout-independent; rendered HTML/CSS remain unchanged.

Out of scope

No functional UI or schema change.

Verification Evidence

ci/teamcity/run_validate.sh: all repository checks pass except workstation CRLF-sensitive D406 fixture checksum; authoritative Linux TeamCity build 11262 passed this step.
python3 -m unittest ci.test_update_gitops_release: 17 passed.
python3 ci/validate_addons.py: all 69 addons validated.
Gemini 3.1 Pro independent review: approved, no blocking findings.
Claude Opus review unavailable because provider credits are insufficient.

Reviewer Focus

Reconciliation trigger forwarding and controlled baseline hashes.

Promotion and Recovery

Promote dev -> test -> main only after branch CI/Qodana and review pass.
Revert this single commit if regression is found.

Identity and Traceability

Human sponsor: Cristian Lorand cristian@moebiusol.eu
Executing agent: Moe Ardent moe.lorand.bot@moebiusol.eu

Closure Checklist

scope is described and bounded
verification evidence is attached or linked
docs and QMS impact is stated
reviewer focus areas are called out
promotion target is explicit
rollback or recovery path is stated

Source PR branches: quality/qodana-zero-11262-v2 -> dev

## Summary - Change class: FIX - Promotion target: dev - Trace ref: MOE-2 / TeamCity 11262 ## Scope ### Included - Remediate all five Qodana findings from exact-main build 11262. - Correct reconciliation fallback trigger selection. - Make controlled prototype validator hashing checkout-independent; rendered HTML/CSS remain unchanged. ### Out of scope - No functional UI or schema change. ## Verification Evidence - `ci/teamcity/run_validate.sh`: all repository checks pass except workstation CRLF-sensitive D406 fixture checksum; authoritative Linux TeamCity build 11262 passed this step. - `python3 -m unittest ci.test_update_gitops_release`: 17 passed. - `python3 ci/validate_addons.py`: all 69 addons validated. - Gemini 3.1 Pro independent review: approved, no blocking findings. - Claude Opus review unavailable because provider credits are insufficient. ## Reviewer Focus - Reconciliation trigger forwarding and controlled baseline hashes. ## Promotion and Recovery - Promote dev -> test -> main only after branch CI/Qodana and review pass. - Revert this single commit if regression is found. ## Identity and Traceability - Human sponsor: Cristian Lorand <cristian@moebiusol.eu> - Executing agent: Moe Ardent <moe.lorand.bot@moebiusol.eu> ## Closure Checklist - [x] scope is described and bounded - [x] verification evidence is attached or linked - [x] docs and QMS impact is stated - [x] reviewer focus areas are called out - [x] promotion target is explicit - [x] rollback or recovery path is stated Source PR branches: quality/qodana-zero-11262-v2 -> dev

moeardent closed this issue

2026-10-09 04:25:53 +00:00

moeardent referenced this issue

2026-10-09 04:25:54 +00:00

[Migrated PR #20] [PROMOTION] MOE-2 dev to test #35

moeardent commented

2026-10-09 04:35:34 +00:00

Author

Owner

Migrated Codeberg review

Reviewer: cristianlorand
State: APPROVED
Submitted: 2026-07-30T00:16:42+02:00
Commit: 041826b6da43a6751ff80373eab82af7e40e0b21

Independent peer review and local validation passed. Approval is bounded to Qodana remediation; TeamCity build 11264 must pass before merge.

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-07-30T00:16:42+02:00` - Commit: `041826b6da43a6751ff80373eab82af7e40e0b21` Independent peer review and local validation passed. Approval is bounded to Qodana remediation; TeamCity build 11264 must pass before merge.

moeardent commented

2026-10-09 04:35:34 +00:00

Author

Owner

Migrated Codeberg review

Reviewer: cristianlorand
State: APPROVED
Submitted: 2026-07-30T02:03:37+02:00
Commit: 2c14cc5a60256422b273d883a09cbff4f1b0d082

Exact commit approved; TeamCity 11265 remains the mandatory pre-merge gate.

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-07-30T02:03:37+02:00` - Commit: `2c14cc5a60256422b273d883a09cbff4f1b0d082` Exact commit approved; TeamCity 11265 remains the mandatory pre-merge gate.