[Migrated PR #50] fix: clear Qodana helper findings before release #3

Closed
opened 2026-10-09 04:25:51 +00:00 by moeardent · 1 comment
Owner

Summary

  • remove the seven Qodana Ultimate findings from test helpers
  • preserve test behavior while avoiding shadowed names
  • move the status helper return outside the context manager for static analysis clarity

Verification

  • python compileall passed
  • Ruff passed
  • git diff --check passed
  • TeamCity Quality build 13465 identified the findings on revision 3c48236; this change targets the correction.

Source PR branches: fix/release-main-attestation -> main

## Summary - remove the seven Qodana Ultimate findings from test helpers - preserve test behavior while avoiding shadowed names - move the status helper return outside the context manager for static analysis clarity ## Verification - python compileall passed - Ruff passed - git diff --check passed - TeamCity Quality build 13465 identified the findings on revision 3c48236; this change targets the correction. Source PR branches: fix/release-main-attestation -> main <!-- migrated-from: pull-request-fallback Moebiusol/odoo-custom-addons #50 -->
Author
Owner

Migrated Codeberg review

  • Reviewer: cristianlorand
  • State: APPROVED
  • Submitted: 2026-08-11T07:42:10+02:00
  • Commit: 9191fa2279d46dcb61fd15b75a78a16a8c3e0cdb

(no review body)

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-08-11T07:42:10+02:00` - Commit: `9191fa2279d46dcb61fd15b75a78a16a8c3e0cdb` (no review body) <!-- migrated-from: review Moebiusol/odoo-custom-addons #1671932 -->
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: moebiusol/odoo-custom-addons#3
No description provided.