[Migrated PR #25] [FIX] Repair dependent-document catalog and actions #31

New issue

Open

opened 2026-10-09 04:25:54 +00:00 by moeardent · 1 comment

moeardent commented

2026-10-09 04:25:54 +00:00

Owner

Summary

Change class: defect remediation
Promotion target: dev
Trace ref: MOE-2 / WP-ODOO-COMMUNITY-001
Related verification: TeamCity build 11242

Scope

Included

Include inactive immutable rule versions in catalog existence checks.
Return fixed module-owned action metadata to authorized accounting users.
Align cross-company fixture with automatic company catalog seeding.
Extend repeated-seed and ordinary-user action regression checks.

Out of scope

No schema, integration, deployment, or unrelated source changes.

Verification Evidence

git diff --check
Python compilation
Ruff on changed files
Full ci/validate_addons.py
Independent reviewer traced all seven build errors to these causes and approved the bounded approach.

Reviewer Focus

active_test=False is limited to catalog existence checks.
sudo() is limited to static module-owned ir.actions.act_window metadata after business authorization.

Promotion and Recovery

Promote dev -> test -> main, then rerun all eight TeamCity gates on exact main revision.
Rollback is branch/revert of this two-file change; no data migration is introduced.

Closure Checklist

scope is described and bounded
verification evidence is linked
reviewer focus areas are called out
promotion target is explicit
rollback shape is stated

Source PR branches: fix/dependent-document-ci-11242 -> dev

## Summary - Change class: defect remediation - Promotion target: dev - Trace ref: MOE-2 / WP-ODOO-COMMUNITY-001 - Related verification: TeamCity build 11242 ## Scope ### Included - Include inactive immutable rule versions in catalog existence checks. - Return fixed module-owned action metadata to authorized accounting users. - Align cross-company fixture with automatic company catalog seeding. - Extend repeated-seed and ordinary-user action regression checks. ### Out of scope - No schema, integration, deployment, or unrelated source changes. ## Verification Evidence - `git diff --check` - Python compilation - Ruff on changed files - Full `ci/validate_addons.py` - Independent reviewer traced all seven build errors to these causes and approved the bounded approach. ## Reviewer Focus - `active_test=False` is limited to catalog existence checks. - `sudo()` is limited to static module-owned `ir.actions.act_window` metadata after business authorization. ## Promotion and Recovery - Promote dev -> test -> main, then rerun all eight TeamCity gates on exact main revision. - Rollback is branch/revert of this two-file change; no data migration is introduced. ## Closure Checklist - [x] scope is described and bounded - [x] verification evidence is linked - [x] reviewer focus areas are called out - [x] promotion target is explicit - [x] rollback shape is stated Source PR branches: fix/dependent-document-ci-11242 -> dev

moeardent referenced this issue

2026-10-09 04:35:34 +00:00

[Migrated PR #32] [PROMOTE] TeamCity expected-log correction to test #23

moeardent commented

2026-10-09 04:35:35 +00:00

Author

Owner

Migrated Codeberg review

Reviewer: cristianlorand
State: APPROVED
Submitted: 2026-07-29T19:39:05+02:00
Commit: 98ed2fbab46a689581337bddb474f907f46b62c4

Independent reviewer evidence for TeamCity build 11242 confirms the bounded repair accounts for all seven errors. Static validation and targeted regression changes are complete. Approved for dev promotion and exact-revision CI rerun.

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-07-29T19:39:05+02:00` - Commit: `98ed2fbab46a689581337bddb474f907f46b62c4` Independent reviewer evidence for TeamCity build 11242 confirms the bounded repair accounts for all seven errors. Static validation and targeted regression changes are complete. Approved for dev promotion and exact-revision CI rerun.