moebiusol/odoo-custom-addons
4
0
Fork 0
Code Issues 2 Pull requests 3 Projects Releases Packages Wiki Activity Actions

[Migrated PR #49] [FIX] Remediate Qodana strict findings #4

New issue
Closed
opened 2026-10-09 04:25:51 +00:00 by moeardent · 2 comments
moeardent commented 2026-10-09 04:25:51 +00:00
Owner
Copy link

Remediates the 22 strict Qodana findings reported by TeamCity quality build 13388. Replaces unsupported PEP604 annotations, resolves naming/shadowing/return/unused-local findings, and narrows justified inspection suppressions with an updated signed config hash. Local contract tests and local batch validation pass.

Source PR branches: fix/qodana-main-remediation -> main

Remediates the 22 strict Qodana findings reported by TeamCity quality build 13388. Replaces unsupported PEP604 annotations, resolves naming/shadowing/return/unused-local findings, and narrows justified inspection suppressions with an updated signed config hash. Local contract tests and local batch validation pass. Source PR branches: fix/qodana-main-remediation -> main <!-- migrated-from: pull-request-fallback Moebiusol/odoo-custom-addons #49 -->
moeardent commented 2026-10-09 04:35:33 +00:00
Author
Owner
Copy link

Migrated Codeberg review

  • Reviewer: cristianlorand
  • State: APPROVED
  • Submitted: 2026-08-10T20:24:00+02:00
  • Commit: b41f02e5b65701ead4b8ecbde9cace793dbe6dbb

(no review body)

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-08-10T20:24:00+02:00` - Commit: `b41f02e5b65701ead4b8ecbde9cace793dbe6dbb` (no review body) <!-- migrated-from: review Moebiusol/odoo-custom-addons #1671335 -->
moeardent commented 2026-10-09 04:35:33 +00:00
Author
Owner
Copy link

Migrated Codeberg review

  • Reviewer: cristianlorand
  • State: APPROVED
  • Submitted: 2026-08-10T20:18:06+02:00
  • Commit: 40ff63c51f178f5217e2473e0223d7fb8772fa9c

(no review body)

### Migrated Codeberg review - Reviewer: `cristianlorand` - State: `APPROVED` - Submitted: `2026-08-10T20:18:06+02:00` - Commit: `40ff63c51f178f5217e2473e0223d7fb8772fa9c` (no review body) <!-- migrated-from: review Moebiusol/odoo-custom-addons #1671293 -->
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/PLAT-122-odoo-default-branch-contract
fix/PLAT-122-odoo-test-urllib3-compatibility
fix/PLAT-122-odoo-builder-inline-contract
fix/PLAT-122-forgejo-coverage-origin
fix/PLAT-122-frozen-anaf-forgejo-base
fix/PLAT-122-frozen-anaf-forgejo-transport
test
fix/PLAT-107-forgejo-consumers-main
fix/PLAT-107-forgejo-consumers-test
dev
fix/PLAT-107-forgejo-consumers-dev
fix/qodana-cleanup-spv-33f553b0
promotion/odoo-spv-intake-33f553b0
fix/promotion-spv-intake-main
18.0
fix/spv-mail-routing-and-parser-dispatch
quality/treasury-parser-coverage
fix/release-secret-mount-permissions
fix/release-main-attestation
fix/qodana-main-remediation
quality/odoo-release-pack-94967c5
quality/efactura-oauth-coverage
quality/qodana-zero-11583
fix/uat-evidence-promotion-gate
fix/complete-odoo-ui-workflows
quality/qodana-zero
fix/teamcity-source-ssh
fix/bank-source-chart-install
fix/prototype-baseline-portability
quality/qodana-zero-11262-v2
fix/dependent-document-expected-log-11255
quality/product-design-gate-ae3caa1d04b3d4f7
fix/dependent-document-ci-11242
fix/dependent-document-oracle-11249
fix/accounting-operational-closure
fix/teamcity-gitops-kubectl
feature/odoo-ci-fiscal-foundation
odoo-ci-fiscal-foundation
No results found.
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: moebiusol/odoo-custom-addons#4
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?