moebiusol/oculus_vita-cms
4
0
Fork 0
Code Issues Pull requests 21 Projects Releases Packages 1 Wiki Activity Actions

[SEC] OCV-229 validate contact return URL origin #61

Open
moeardent wants to merge 6 commits from moeardent/fix/OCV-229-contact-return-origin into dev AGit
pull from: moeardent/fix/OCV-229-contact-return-origin
merge into: moebiusol:dev
Conversation 0 Commits 6 Files changed 11 +385 -11
moeardent commented 2026-10-14 10:07:01 +00:00
Owner
Copy link

Require exact HTTP(S) scheme, host and effective port for absolute returns; retain safe root-relative paths and form anchor. Reject ambiguous and cross-origin values to the routed fallback. Add production-method and POST regression checks to validation CI.

Agent-Identity: Moe Ardent moe.lorand.bot@moebiusol.eu
Agent-Role: worker
Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]
Verification-Ref: specs/ocv-229-contact-return-origin/verification.md

Require exact HTTP(S) scheme, host and effective port for absolute returns; retain safe root-relative paths and form anchor. Reject ambiguous and cross-origin values to the routed fallback. Add production-method and POST regression checks to validation CI. Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu> Agent-Role: worker Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229] Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[SEC] OCV-229 validate contact return URL origin
Some checks failed
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch failed with exit 255
Details
527d082c2a 
Require exact HTTP(S) scheme, host and effective port for absolute returns; retain safe root-relative paths and form anchor. Reject ambiguous and cross-origin values to the routed fallback. Add production-method and POST regression checks to validation CI.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>
Agent-Role: worker
Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]
Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[FIX] OCV-229 admit work refs for source validation only
Some checks failed
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch failed with exit 255
Details
96137e0587 
Repair native source-contract rejection of configured feature/fix/quality validation branches. Keep Build, Security and Promote restricted to protected routes and retain exact producer source/stage parity. Add fail-closed coverage for malformed refs, nondefault identity and producer-chain isolation.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>
Agent-Role: worker
Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]
Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[FIX] OCV-229 derive DEV destinations for verified source validation
Some checks failed
teamcity/medcms/validate TeamCity OculusVitaCMS_Validate failed with exit 255
Details
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch failed with exit 255
Details
bf23196be3 
Keep work-ref provenance intact while mapping only verified Validate route contexts to DEV compatibility destinations. Leave protected artifact/deployment routing unchanged. Exercise real native verification, checkout identity, launcher and dispatcher together with fail-closed integration tests.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>
Agent-Role: worker
Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]
Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[FIX] OCV-229 clear Qodana findings in redirect harness
Some checks failed
teamcity/medcms/validate TeamCity OculusVitaCMS_Validate failed with exit 255
Details
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch failed with exit 255
Details
34807ad3bf 
Make Joomla test doubles consume their parameters, use local imports and explicit exception reporting, and apply readonly/constant style without changing production redirect behavior. Record build 21814 findings and required exact-head revalidation.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>

Agent-Role: local-executor

Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]

Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[FIX] OCV-229 mark immutable contact test double readonly
Some checks failed
teamcity/medcms/validate TeamCity OculusVitaCMS_Validate failed with exit 255
Details
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch failed with exit 255
Details
675bd46d4c 
Resolve the sole Qodana finding on exact-head CMS Validate build 21820 without changing production redirect behavior or test cases.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>

Agent-Role: local-executor

Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]

Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
[FIX] OCV-229 avoid redundant readonly modifier
Some checks failed
teamcity/medcms/validate TeamCity OculusVitaCMS_Validate passed
Details
teamcity/medcms/sbom-source TeamCity OculusVitaCMS_Validate passed
Details
teamcity/medcms/grype-source TeamCity OculusVitaCMS_Validate failed with exit 2
Details
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch passed
Details
03d4280e74 
Qodana found one redundant property modifier after the test double became a readonly class. Remove only that modifier; all 30 redirect cases and 95 CI unit tests remain green.

Agent-Identity: Moe Ardent <moe.lorand.bot@moebiusol.eu>

Agent-Role: local-executor

Trace-Ref: OCV-229 [https://moebiusol.youtrack.cloud/issue/OCV-229]

Verification-Ref: specs/ocv-229-contact-return-origin/verification.md
Some checks failed
teamcity/medcms/validate TeamCity OculusVitaCMS_Validate passed
Details
teamcity/medcms/sbom-source TeamCity OculusVitaCMS_Validate passed
Details
teamcity/medcms/grype-source TeamCity OculusVitaCMS_Validate failed with exit 2
Details
teamcity/medcms/qodana-branch TeamCity OculusVitaCMS_QodanaBranch passed
Required
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin +refs/pull/61/head:moeardent/fix/OCV-229-contact-return-origin
git switch moeardent/fix/OCV-229-contact-return-origin
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: moebiusol/oculus_vita-cms#61
No description provided.
Delete branch "moeardent/fix/OCV-229-contact-return-origin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?